bpo-32051: update multiprocessing doc #4469
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
1a1a11a
changed the title
1a1a11a
changed the title
|
I have signed the CLA, waiting for system to pass and re-check. |
Doc/library/multiprocessing.rst
Outdated
| @@ -1837,8 +1837,8 @@ Running the following commands creates a server for a single shared queue which | |||
| remote clients can access:: | |||
|
|
|||
| >>> from multiprocessing.managers import BaseManager | |||
| >>> import queue | |||
| >>> queue = queue.Queue() | |||
| >>> from multiprocessing import Queue | |||
There was a problem hiding this comment.
I don't think multiprocessing.Queue is needed here. We don't communicate between different processes in the same machine so using queue.Queue is OK.
There was a problem hiding this comment.
thank you for the comment, what should I do now? Should I make the change and submit a new pull request?
There was a problem hiding this comment.
You don't need to submit a new pull request. You can make the requested changes and push to your existing branch. In your case, that would be the master branch.
You can follow the guide at https://devguide.python.org/pullrequest/#step-by-step-guide for your future pull requests.
| @@ -0,0 +1,2 @@ | |||
| Remove name conflict under "Using a remove manager" section, the original | |||
There was a problem hiding this comment.
No need to add a NEWS entry for trivial documentation changes. Please delete this file.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @berkerpeksag: please review the changes made to this pull request. |
Remove name conflict under "Using a remove manager" section
1a1a11a
changed the title
1a1a11a
changed the title
1a1a11a
changed the title
|
btw, how do I add skip news label? |
berkerpeksag
changed the title
|
Thanks @1a1a11a for the PR, and @berkerpeksag for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6. |
|
GH-4577 is a backport of this pull request to the 3.6 branch. |
(cherry picked from commit c172fc5)
|
Thanks! Labels can only be set by Python core developers or bots like bedevere. |
|
thank you! |
Remove name conflict under "Using a remove manager" section, the original usage of queue conflicts with module name queue.
https://bugs.python.org/issue32051