Fix BaseServer.finish_request arguments in docs #4445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Show missing arguments (request, client_address).
berkerpeksag
approved these changes
Nov 19, 2017
|
Thanks @ma8ma for the PR, and @berkerpeksag for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6. |
|
Thanks! |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 19, 2017
(cherry picked from commit 7750bde)
|
GH-4460 is a backport of this pull request to the 3.6 branch. |
berkerpeksag
pushed a commit
that referenced
this pull request
Nov 19, 2017
(cherry picked from commit 7750bde)
|
@berkerpeksag Thanks for merging 😄 I submit a patch to typeshed soon. |
ma8ma
added a commit
to ma8ma/typeshed
that referenced
this pull request
Nov 19, 2017
ma8ma
added a commit
to ma8ma/cpython
that referenced
this pull request
Nov 19, 2017
(cherry picked from commit 7750bde)
berkerpeksag
pushed a commit
that referenced
this pull request
Nov 19, 2017
(cherry picked from commit 7750bde)
JelleZijlstra
pushed a commit
to python/typeshed
that referenced
this pull request
Nov 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
socketserver.BaseServer.finish_requesthas two arguments(request, client_address), but they have been omitted in the document.Source: https://github.com/python/cpython/blob/master/Lib/socketserver.py#L355
Documents: https://docs.python.org/3/library/socketserver.html#socketserver.BaseServer.finish_request