Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-31822 Document that urllib.parse.{Defrag,Split,Parse}Result are namedtuples #4434

Merged
merged 6 commits into from
Mar 24, 2019
Merged

bpo-31822 Document that urllib.parse.{Defrag,Split,Parse}Result are namedtuples #4434

merged 6 commits into from
Mar 24, 2019

Conversation

lisroach
Copy link
Contributor

@lisroach lisroach commented Nov 17, 2017 •
edited by bedevere-bot
Loading

@lisroach
Copy link
Contributor Author

I think 'skip-news' could be added here to get this passing checks.

@csabella
Copy link
Contributor

I resolved the merge conflict. @lisroach and @merwok, I believe this one can be merged, but you may want to look it over once more. Thanks!

csabella
csabella approved these changes Mar 18, 2019
View reviewed changes
Copy link
Contributor

@csabella csabella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csabella csabella merged commit 13c1f72 into python:master Mar 24, 2019
@miss-islington
Copy link
Contributor

Thanks @lisroach for the PR, and @csabella for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@csabella
Copy link
Contributor

Thanks @lisroach for the PR and @merwok and @tirkarthi for the reviews.

@miss-islington
Copy link
Contributor

Thanks @lisroach for the PR, and @csabella for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-12528 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 24, 2019
@lisroach @miss-islington
bpo-31822: Document that urllib.parse.{Defrag,Split,Parse}Result are …
b4ca3a1 
…namedtuples (pythonGH-4434)

(cherry picked from commit 13c1f72)

Co-authored-by: Lisa Roach <lisaroach14@gmail.com>
miss-islington added a commit that referenced this pull request Mar 24, 2019
@miss-islington @lisroach
bpo-31822: Document that urllib.parse.{Defrag,Split,Parse}Result are …
fc00102 
…namedtuples (GH-4434)

(cherry picked from commit 13c1f72)

Co-authored-by: Lisa Roach <lisaroach14@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tirkarthi tirkarthi tirkarthi left review comments

@merwok merwok merwok approved these changes

@csabella csabella csabella approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lisroach @csabella @miss-islington @bedevere-bot @merwok @tirkarthi @the-knights-who-say-ni