Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-31948: Broken MSDN links in msilib docs #4397

Merged
merged 1 commit into from
Nov 14, 2017

Conversation

Jesse-Bakker
Copy link
Contributor

@Jesse-Bakker Jesse-Bakker commented Nov 14, 2017

bpo-31948: Fix broken MSDN links in msilib docs

https://bugs.python.org/issue31948

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@Jesse-Bakker Jesse-Bakker changed the title Fix broken links in msilib docs bpo-31948: Broken MSDN links in msilib docs Nov 14, 2017
@Mariatta Mariatta added docs Documentation in the Doc dir needs backport to 3.6 skip news labels Nov 14, 2017
Copy link
Member

@Mariatta Mariatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The NEWS entry is not needed. Please remove it. Otherwise, everything else looks great!

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@Jesse-Bakker Jesse-Bakker force-pushed the fix-broken-msilib-links branch from 36ae599 to b622529 Compare November 14, 2017 23:01
@Jesse-Bakker
Copy link
Contributor Author

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@Mariatta: please review the changes made to this pull request.

@miss-islington
Copy link
Contributor

Thanks @Jesse-Bakker for the PR, and @Mariatta for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@Mariatta
Copy link
Member

Thanks @Jesse-Bakker and congrats on your first contribution to CPython 🌮

@miss-islington
Copy link
Contributor

Sorry, @Jesse-Bakker and @Mariatta, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 3bda02222aa3783bf85fc3ff8bc042aefd9c4fd3 3.6

@Mariatta
Copy link
Member

@Jesse-Bakker could you prepare the backport PR against 3.6 branch?
Thanks.

@Jesse-Bakker
Copy link
Contributor Author

@Mariatta Will do!

Jesse-Bakker added a commit to Jesse-Bakker/cpython that referenced this pull request Nov 14, 2017
@bedevere-bot
Copy link

GH-4398 is a backport of this pull request to the 3.6 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants