-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-31948: Broken MSDN links in msilib docs #4397
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! The NEWS entry is not needed. Please remove it. Otherwise, everything else looks great!
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
36ae599
to
b622529
Compare
I have made the requested changes; please review again. |
Thanks for making the requested changes! @Mariatta: please review the changes made to this pull request. |
Thanks @Jesse-Bakker for the PR, and @Mariatta for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6. |
Thanks @Jesse-Bakker and congrats on your first contribution to CPython 🌮 |
Sorry, @Jesse-Bakker and @Mariatta, I could not cleanly backport this to |
@Jesse-Bakker could you prepare the backport PR against 3.6 branch? |
@Mariatta Will do! |
(cherry picked from commit 3bda022)
GH-4398 is a backport of this pull request to the 3.6 branch. |
bpo-31948: Fix broken MSDN links in msilib docs
https://bugs.python.org/issue31948