Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant 'exc = True' line #4357

Merged
merged 1 commit into from
Nov 11, 2017
Merged

Conversation

berkerpeksag
Copy link
Member

It can be removed after python/peps@c28890f

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

After merging try...except and try...finally in try...exept...else the exc flag no longer needed.

The same change should be made in PEP 492 (if this is not done yet).

@berkerpeksag
Copy link
Member Author

The same change should be made in PEP 492 (if this is not done yet).

Done in python/peps@cd78f23.

@berkerpeksag berkerpeksag merged commit 7c9da3e into master Nov 11, 2017
@miss-islington
Copy link
Contributor

Thanks @berkerpeksag for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@berkerpeksag berkerpeksag deleted the berkerpeksag-patch-1 branch November 11, 2017 14:55
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 11, 2017
It can be removed after python/peps@c28890f
(cherry picked from commit 7c9da3e)
@bedevere-bot
Copy link

GH-4372 is a backport of this pull request to the 3.6 branch.

berkerpeksag pushed a commit that referenced this pull request Nov 11, 2017
It can be removed after python/peps@c28890f
(cherry picked from commit 7c9da3e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants