Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-28791: Update OS X installer to use SQLite 3.21.0. #4245

Merged
merged 1 commit into from
Dec 5, 2017
Merged

bpo-28791: Update OS X installer to use SQLite 3.21.0. #4245

merged 1 commit into from
Dec 5, 2017

Conversation

Mariatta
Copy link
Member

@Mariatta Mariatta commented Nov 3, 2017 •
edited by bedevere-bot
Loading

@Mariatta Mariatta requested a review from ned-deily November 3, 2017 03:23
mlouielu
mlouielu approved these changes Nov 3, 2017
View reviewed changes
Copy link
Contributor

@mlouielu mlouielu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version, url and checksum looks good.

ned-deily
ned-deily reviewed Nov 3, 2017
View reviewed changes
Copy link
Member

@ned-deily ned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I would prefer that this not be applied yet until I've had a chance to review and test the SQLite updates in the installer build context prior to the next alpha.

@Mariatta
Copy link
Member Author

Mariatta commented Nov 4, 2017

Thanks @ned-deily. Should I mark this as wip?
BTW I made the corresponding PR for the windows build in #4246.

@ned-deily
Copy link
Member

It’s fine as is. I just won’t be able to get to it immediately.

@Mariatta
Copy link
Member Author

Mariatta commented Dec 4, 2017

@ned-deily Will it be possible to include this in 3.7.0a3? Thanks.

@ned-deily
Copy link
Member

I'm working on it now :)

@ned-deily ned-deily merged commit ca7562a into python:master Dec 5, 2017
@ned-deily
Copy link
Member

LGTM, thanks!

ned-deily pushed a commit to ned-deily/cpython that referenced this pull request Dec 5, 2017
@Mariatta @ned-deily
bpo-28791: Update macOS installer to use SQLite 3.21.0. (python#4245)
f1f436f
ned-deily added a commit that referenced this pull request Dec 5, 2017
@ned-deily
[3.6] bpo-28791: Update macOS installer to use SQLite 3.21.0. (#4245) (…
a72e7bf 
…#4711)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ned-deily ned-deily ned-deily left review comments

@mlouielu mlouielu mlouielu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Mariatta @ned-deily @mlouielu @the-knights-who-say-ni @bedevere-bot