bpo-25720: Fix the method for checking pad state of curses WINDOW #4164
Conversation
Modify the code to use ncurses is_pad() instead of checking WINDOW _flags field. If your platform does not provide the is_pad(), the existing way that checks the field will be enabled. Note: This change does not drop support for platforms where do not have both WINDOW _flags field and is_pad().
There was a problem hiding this comment.
The configure check doesn't work. The testing code is compiled successfully since implicit declaration of functions is not an error in C. This results to false detection of the is_pad function and compilation failure on NetBSD.
Look at recently added checks for other curses functions/macros.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
@serhiy-storchaka I see 👍 |
|
Thanks for making the requested changes! @serhiy-storchaka: please review the changes made to this pull request. |
serhiy-storchaka
added
needs backport to 2.7
type-bug
|
Thanks @ma8ma for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6. |
…thonGH-4164) Modify the code to use ncurses is_pad() instead of checking WINDOW _flags field. If your platform does not provide the is_pad(), the existing way that checks the field will be enabled. Note: This change does not drop support for platforms where do not have both WINDOW _flags field and is_pad(). (cherry picked from commit 8bc7d63)
|
GH-4212 is a backport of this pull request to the 3.6 branch. |
…thonGH-4164) Modify the code to use ncurses is_pad() instead of checking WINDOW _flags field. If your platform does not provide the is_pad(), the existing way that checks the field will be enabled. Note: This change does not drop support for platforms where do not have both WINDOW _flags field and is_pad(). (cherry picked from commit 8bc7d63)
|
GH-4213 is a backport of this pull request to the 2.7 branch. |
…-4164) (#4212) Modify the code to use ncurses is_pad() instead of checking WINDOW _flags field. If your platform does not provide the is_pad(), the existing way that checks the field will be enabled. Note: This change does not drop support for platforms where do not have both WINDOW _flags field and is_pad(). (cherry picked from commit 8bc7d63)
…-4164) (#4213) Modify the code to use ncurses is_pad() instead of checking WINDOW _flags field. If your platform does not provide the is_pad(), the existing way that checks the field will be enabled. Note: This change does not drop support for platforms where do not have both WINDOW _flags field and is_pad(). (cherry picked from commit 8bc7d63)
|
@serhiy-storchaka Thank you for merging! |
…thon#4164) Modify the code to use ncurses is_pad() instead of checking WINDOW _flags field. If your platform does not provide the is_pad(), the existing way that checks the field will be enabled. Note: This change does not drop support for platforms where do not have both WINDOW _flags field and is_pad().
Highlights of changes
_flagsfield.is_padfunction/macro.NCURSES_OPAQUEfor Apple-specific.NCURSES_OPAQUEas zero in the case of nois_pad()and having WINDOW_flags.WINDOW_HAS_FLAGSwhen having ncurses.h.HAVE_CURSES_IS_PADwhen having ncurses.h.py_is_pad()macro ifHAVE_CURSES_IS_PADorWINDOW_HAS_FLAGSare defined.WINDOW_HAS_FLAGSwithpy_is_pad.Motivation
WINDOW_HAS_FLAGSwill be defined by configure check, but if your platform has ncurses.h, defines the macro always. Therefore, codes which check the WINDOW_flagsfield are enabled regardless ofNCURSES_OPAQUE(added since ncurses 5.7), and a compile error occurs on platforms where WINDOW is actually opaque.For this reason, these codes are modified to use ncurses
is_pad()instead of checking the field. If your platform does not provide theis_pad()(added since ncurses 5.8 as a ncurses-specific feature), the existing way that checks the field will be enabled. In this case,NCURSES_OPAQUEis defined as zero before including [n]curses.h, for exposing WINDOW fields regardless of the configuraton.Note: This change does not drop support for platforms where do not have both WINDOW
_flagsfield andis_pad().https://bugs.python.org/issue25720