Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-20486: Implement Database.Close() method in msilib #4141

Merged
merged 3 commits into from
Nov 7, 2017
Merged

bpo-20486: Implement Database.Close() method in msilib #4141

merged 3 commits into from
Nov 7, 2017

Conversation

berkerpeksag
Copy link
Member

@berkerpeksag berkerpeksag commented Oct 26, 2017 •
edited by bedevere-bot
Loading

@berkerpeksag berkerpeksag requested a review from a team as a code owner October 26, 2017 20:06
zware
zware approved these changes Nov 6, 2017
View reviewed changes
Copy link
Member

@zware zware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine as far as I can tell, but I have no real familiarity with the msilb module or MSIs in general.

@berkerpeksag
Copy link
Member Author

@zware thanks for the review! I just renamed msiobj_close to msidb_close to make it consistent with the existing naming scheme. I've also test the example in the bug report on my Windows box:

>>> import msilib as m
>>> db = m.OpenDatabase('py33.msi', m.MSIDBOPEN_TRANSACT)
>>> db.Commit()
>>> db2 = m.OpenDatabase('py33.msi', m.MSIDBOPEN_TRANSACT)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
_msi.MSIError: 1: 2203 2: py33.msi 3: -2147287008
>>> db.Close()
>>> db2 = m.OpenDatabase('py33.msi', m.MSIDBOPEN_TRANSACT)

@berkerpeksag berkerpeksag merged commit a935654 into python:master Nov 7, 2017
@berkerpeksag berkerpeksag deleted the 20486-msi-db-close branch November 7, 2017 12:58
embray pushed a commit to embray/cpython that referenced this pull request Nov 9, 2017
@berkerpeksag @embray
bpo-20486: Implement Database.Close() method in msilib (pythonGH-4141)
bea1e09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zware zware zware approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@berkerpeksag @zware @the-knights-who-say-ni @bedevere-bot