gh-76002: asyncio: allow pause_reading() from connection_made()#4053
gh-76002: asyncio: allow pause_reading() from connection_made()#4053pitrou wants to merge 2 commits intopython:mainfrom
Conversation
pitrou
added
needs backport to 3.6
type-bug
|
Hm. We'll need to run tests from the uvloop (has more functional tests) project with this patch. |
|
But I like the change. Let me think about it for a few days. |
|
No pb! |
|
@1st1 any update here? |
| self._loop.call_soon(self._loop._add_reader, | ||
| self._sock_fd, self._read_ready) | ||
| if waiter is not None: | ||
| def _call_connection_made(): |
There was a problem hiding this comment.
Convert nested function into instance method maybe?
|
I like the PR but the came approach should be added to all transports (SSL and pipes) IMHO. |
|
I removed the " needs backport to 3.6" label, the 3.6 branch no longer accept bugfixes (only security fixes are accepted): https://devguide.python.org/#status-of-python-branches |
|
This PR is stale because it has been open for 30 days with no activity. |
github-actions
bot
removed
the
stale
|
This PR is stale because it has been open for 30 days with no activity. |
AlexWaygood
changed the title
AlexWaygood
changed the title
github-actions
bot
removed
the
stale
kumaraditya303
left a comment
kumaraditya303
left a comment
There was a problem hiding this comment.
There are merge conflicts.
|
When you're done making the requested changes, leave the comment: |
|
This PR is stale because it has been open for 30 days with no activity. |
|
Closing as there are merge conflicts. |
12 participants
Uh oh!
There was an error while loading. Please reload this page.