-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-31853: Replaced socket.method calls with super() in SSLSocket. #4048
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
2354d0f
to
5d78918
Compare
@tiran Is there anything stalling this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I forgot about your patch. LGTM, please fix indention and I'll merge it later today.
Lib/ssl.py
Outdated
@@ -781,17 +781,16 @@ def __init__(self, sock=None, keyfile=None, certfile=None, | |||
self.do_handshake_on_connect = do_handshake_on_connect | |||
self.suppress_ragged_eofs = suppress_ragged_eofs | |||
if sock is not None: | |||
socket.__init__(self, | |||
family=sock.family, | |||
super().__init__(family=sock.family, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix indention
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be done. One attribute per line seems to be the style.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase And if you don't make the requested changes, you will be put in the comfy chair! |
5d78918
to
08075f7
Compare
Yeah, it looks fine now. Thanks for your contribution |
@tiran: Please replace |
https://bugs.python.org/issue31853