Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-31787: Prevent refleaks when calling __init__() more than once #3995

Merged
merged 20 commits into from
Feb 13, 2018
Merged

bpo-31787: Prevent refleaks when calling __init__() more than once #3995

merged 20 commits into from
Feb 13, 2018

Conversation

orenmn
Copy link
Contributor

@orenmn orenmn commented Oct 14, 2017 •
edited by bedevere-bot
Loading

@orenmn orenmn requested a review from 1st1 as a code owner October 14, 2017 09:43
@rhettinger
Copy link
Contributor

Please add some tests that exercise doubled calls to __init__ (showing refleaks before the patch and not showing refleaks after the patch).

@orenmn orenmn requested a review from asvetlov as a code owner January 22, 2018 07:12
methane
methane approved these changes Jan 25, 2018
View reviewed changes
Copy link
Member

@methane methane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you merge master again?

@orenmn
Copy link
Contributor Author

orenmn commented Jan 25, 2018

I merged with master on my Windows 10, and now test_asyncio fails.
I am sorry, but i am too busy these days, and don't have time to work on this.

So it would be great if you took it from here...

@methane
Copy link
Member

methane commented Feb 13, 2018

Hm, it seems calling Task.__init__() is not allowed.
I'll revert test and fix for asyncio.

@methane methane changed the title bpo-31787: Prevent various refleaks when calling the __init__() method of some objects more than once bpo-31787: Prevent refleaks when calling __init__() more than once Feb 13, 2018
@methane methane merged commit d019bc8 into python:master Feb 13, 2018
@miss-islington
Copy link
Contributor

Thanks @orenmn for the PR, and @methane for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-5657 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 13, 2018
@orenmn @miss-islington
bpo-31787: Prevent refleaks when calling __init__() more than once (p…
05670ac 
…ythonGH-3995)

(cherry picked from commit d019bc8)

Co-authored-by: Oren Milman <orenmn@gmail.com>
@miss-islington
Copy link
Contributor

Sorry, @orenmn and @methane, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker d019bc8319ea35e93bf4baa38098ff1b57cd3ee5 3.6

miss-islington added a commit that referenced this pull request Feb 13, 2018
@miss-islington @orenmn
bpo-31787: Prevent refleaks when calling __init__() more than once (G…
ef20abe 
…H-3995)

(cherry picked from commit d019bc8)

Co-authored-by: Oren Milman <orenmn@gmail.com>
methane pushed a commit to methane/cpython that referenced this pull request Feb 13, 2018
@orenmn @methane
bpo-31787: Prevent refleaks when calling __init__() more than once (p…
44b10a0 
…ythonGH-3995)

(cherry picked from commit d019bc8)
@bedevere-bot
Copy link

GH-5659 is a backport of this pull request to the 3.6 branch.

methane added a commit that referenced this pull request Feb 13, 2018
@methane
bpo-31787: Prevent refleaks when calling __init__() more than once (G…
4731634 
…H-3995)

(cherry picked from commit d019bc8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@methane methane methane approved these changes

@rhettinger rhettinger rhettinger approved these changes

@1st1 1st1 Awaiting requested review from 1st1

@asvetlov asvetlov Awaiting requested review from asvetlov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@orenmn @rhettinger @methane @miss-islington @bedevere-bot @the-knights-who-say-ni