Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.6] bpo-25588: Fix regrtest when run inside IDLE (GH-3962) #3987

Merged
merged 1 commit into from
Oct 13, 2017

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Oct 13, 2017

When regrtest in run inside IDLE, sys.stdout and sys.stderr are not
TextIOWrapper objects and have no file descriptor associated:
sys.stderr.fileno() raises io.UnsupportedOperation.

Disable faulthandler and don't replace sys.stdout in that case.
(cherry picked from commit ccef823)

https://bugs.python.org/issue25588

When regrtest in run inside IDLE, sys.stdout and sys.stderr are not
TextIOWrapper objects and have no file descriptor associated:
sys.stderr.fileno() raises io.UnsupportedOperation.

Disable faulthandler and don't replace sys.stdout in that case.
(cherry picked from commit ccef823)
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington
Copy link
Contributor Author

@Haypo: Backport status check is done, and it's a success ✅ .

@vstinner vstinner merged commit 6234e90 into python:3.6 Oct 13, 2017
@miss-islington
Copy link
Contributor Author

Thanks, @Haypo!

@miss-islington miss-islington deleted the backport-ccef823-3.6 branch October 13, 2017 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants