Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-31567: fix more decorator markup in docs (GH-3959) #3966

Merged
merged 3 commits into from
Oct 12, 2017
Merged

bpo-31567: fix more decorator markup in docs (GH-3959) #3966

merged 3 commits into from
Oct 12, 2017

Conversation

merwok
Copy link
Member

@merwok merwok commented Oct 12, 2017 •
edited by bedevere-bot
Loading

@merwok merwok self-assigned this Oct 12, 2017
merwok
merwok commented Oct 12, 2017
View reviewed changes
Doc/library/typing.rst
@@ -897,7 +897,7 @@ The module defines the following classes, functions and decorators:

See :pep:`484` for details and comparison with other typing semantics.

.. decorator:: no_type_check(arg)
.. decorator:: no_type_check

Decorator to indicate that annotations are not type hints.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixing the text after this

@merwok merwok requested a review from berkerpeksag October 12, 2017 15:31
@merwok
Copy link
Member Author

merwok commented Oct 12, 2017

I may use this PR to also address feedback received on the ticket.

@merwok merwok merged commit 03b9537 into python:master Oct 12, 2017
@merwok merwok deleted the fix-issue-31567 branch October 12, 2017 16:29
merwok pushed a commit that referenced this pull request Oct 12, 2017
@miss-islington @merwok
[3.6] bpo-31567: add or fix decorator markup in docs (GH-3959) (GH-3966)
205dd4e 
(cherry picked from commit 0e61e67)
@ilevkivskyi
Copy link
Member

@merwok Please mention me and/or Guido when making changes to typing-related files (this will simplify life since typing is still developed in a separate repo).

@merwok
Copy link
Member Author

merwok commented Dec 5, 2017

Sure! Could you have your names in the code owners file?

@ilevkivskyi
Copy link
Member

Could you have your names in the code owners file?

This is an interesting idea. I am not a core-dev but @gvanrossum maybe you can add yourself as a code owner for typing.py and test_typing.py?

@gvanrossum
Copy link
Member

I'm happy to be listed as owner for typing.py etc. but I don't know how this is administered.

@merwok
Copy link
Member Author

merwok commented Dec 5, 2017

This file maps repo file patterns to github usernames or team names:
https://github.com/python/cpython/blob/master/.github/CODEOWNERS

@gvanrossum gvanrossum mentioned this pull request Dec 5, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

Assignees

@merwok merwok

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@merwok @ilevkivskyi @gvanrossum @the-knights-who-say-ni @bedevere-bot