os.startfile(): add a C comment on security #3877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LoadLibrary("SHELL32") is not vulnerable to DLL injection.
|
@zooba gave me the link https://blogs.msdn.microsoft.com/larryosterman/2004/07/19/what-are-known-dlls-anyway/ but I don't think that it's worth it to mention it in the comment. |
zooba
reviewed
Oct 3, 2017
Modules/posixmodule.c
Outdated
| @@ -10559,6 +10559,10 @@ check_ShellExecute() | |||
| /* only recheck */ | |||
| if (-1 == has_ShellExecute) { | |||
| Py_BEGIN_ALLOW_THREADS | |||
| /* Security note: this call is not vulnerable to "DLL injection". | |||
| SHELL32 is part of "KnownDLL" and so Windows always load | |||
Modules/posixmodule.c
Outdated
| @@ -10559,6 +10559,10 @@ check_ShellExecute() | |||
| /* only recheck */ | |||
| if (-1 == has_ShellExecute) { | |||
| Py_BEGIN_ALLOW_THREADS | |||
| /* Security note: this call is not vulnerable to "DLL injection". | |||
| SHELL32 is part of "KnownDLL" and so Windows always load | |||
| the system SHELL32.DLL, even if they are other SHELL32.DLL | |||
zooba
reviewed
Oct 3, 2017
Modules/posixmodule.c
Outdated
| @@ -10559,6 +10559,10 @@ check_ShellExecute() | |||
| /* only recheck */ | |||
| if (-1 == has_ShellExecute) { | |||
| Py_BEGIN_ALLOW_THREADS | |||
| /* Security note: this call is not vulnerable to "DLL injection". | |||
There was a problem hiding this comment.
Strictly, it's DLL hijacking. DLL injection is something else.
|
Thank you for your review :-) I rewrote the comment according to your remarks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LoadLibrary("SHELL32") is not vulnerable to DLL injection.