Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made json.dumps() example PEP-8 compliant. #3472

Merged
merged 1 commit into from
Sep 9, 2017
Merged

Made json.dumps() example PEP-8 compliant. #3472

merged 1 commit into from
Sep 9, 2017

Conversation

sir-sigurd
Copy link
Contributor

No description provided.

@Mariatta Mariatta merged commit a7fbad9 into python:master Sep 9, 2017
@miss-islington
Copy link
Contributor 

        Thanks @sir-sigurd for the PR, and @Mariatta for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6.
        🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2017
@sir-sigurd @miss-islington
[3.6] Make json.dumps() example to be PEP-8 compliant. (pythonGH-3472)
a1ca054 
(cherry picked from commit a7fbad9)
@bedevere-bot
Copy link

GH-3473 is a backport of this pull request to the 3.6 branch.

@sir-sigurd sir-sigurd deleted the json-example branch September 9, 2017 16:48
@Mariatta Mariatta mentioned this pull request Sep 9, 2017
Merged
@miss-islington
Copy link
Contributor

Sorry, @sir-sigurd and @Mariatta, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.

@Mariatta
Copy link
Member

Mariatta commented Sep 9, 2017

Let's not bother with 2.7 then.

Mariatta pushed a commit that referenced this pull request Sep 9, 2017
@miss-islington @Mariatta
[3.6] Make json.dumps() example to be PEP-8 compliant. (GH-3472) (G…
fe9bebf 
…H-3473)

(cherry picked from commit a7fbad9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mariatta Mariatta Mariatta approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sir-sigurd @miss-islington @bedevere-bot @Mariatta @the-knights-who-say-ni