bpo-31036: Allow sphinx and blurb to be found automatically #3440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Brett's done all the reviewing so far, but he's on vacation from Python this month. I don't mind reviewing it but I'm likely to just rubber-stamp it. I can do that if that's what you want ;-) |
|
🐍🍒⛏🤖 Thanks @ned-deily for the PR, and @ned-deily for merging it 🌮🎉.I'm working now to backport this PR to: 3.6. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 8, 2017
…thonGH-3440) Rather than requiring the path to blurb and/or sphinx-build to be specified to the make rule, enhance the Doc/Makefile to look for each first in a virtual environment created by make venv and, if not found, look on the normal process PATH. This allows the Doc/Makefile to take advantage of an installed spinx-build or blurb and, thus, do the right thing most of the time. Also, make the directory for the venv be configurable and document the `make venv` target. (cherry picked from commit 590665c)
|
GH-3441 is a backport of this pull request to the 3.6 branch. |
ned-deily
pushed a commit
that referenced
this pull request
Sep 8, 2017
…-3440) (#3441) Rather than requiring the path to blurb and/or sphinx-build to be specified to the make rule, enhance the Doc/Makefile to look for each first in a virtual environment created by make venv and, if not found, look on the normal process PATH. This allows the Doc/Makefile to take advantage of an installed spinx-build or blurb and, thus, do the right thing most of the time. Also, make the directory for the venv be configurable and document the `make venv` target. (cherry picked from commit 590665c)
ned-deily
added a commit
that referenced
this pull request
Sep 8, 2017
…-3440) Rather than requiring the path to blurb and/or sphinx-build to be specified to the make rule, enhance the Doc/Makefile to look for each first in a virtual environment created by make venv and, if not found, look on the normal process PATH. This allows the Doc/Makefile to take advantage of an installed spinx-build or blurb and, thus, do the right thing most of the time. Also, make the directory for the venv be configurable and document the `make venv` target.
|
Thanks @ned-deily for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7. |
|
Sorry, @ned-deily, I could not cleanly backport this to |
benjaminp
pushed a commit
that referenced
this pull request
Oct 8, 2019
…-3440) Rather than requiring the path to blurb and/or sphinx-build to be specified to the make rule, enhance the Doc/Makefile to look for each first in a virtual environment created by make venv and, if not found, look on the normal process PATH. This allows the Doc/Makefile to take advantage of an installed spinx-build or blurb and, thus, do the right thing most of the time. Also, make the directory for the venv be configurable and document the `make venv` target.. (cherry picked from commit 590665c) Co-authored-by: Ned Deily <nad@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than requiring the path to
blurband/orsphinx-buildto be specified to the make rule, enhance the Doc/Makefile to look for each first in a virtual environment created bymake venvand, if not found, look on the normal processPATH. This allows the Doc/Makefile to take advantage of an installedspinx-buildorblurband, thus, do the right thing most of the time.https://bugs.python.org/issue31036