Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-31307: Allow use of bytes object as a single argument in ConfigParser.read #3420

Merged
merged 7 commits into from
Nov 2, 2017
Merged

bpo-31307: Allow use of bytes object as a single argument in ConfigParser.read #3420

merged 7 commits into from
Nov 2, 2017

Conversation

vxgmichel
Copy link
Contributor

@vxgmichel vxgmichel commented Sep 7, 2017 •
edited by bedevere-bot
Loading

berkerpeksag
berkerpeksag requested changes Oct 31, 2017
View reviewed changes
Lib/test/test_configparser.py Outdated
@@ -739,6 +740,18 @@ def test_read_returns_file_list(self):
cf = self.newconfig()
parsed_files = cf.read([])
self.assertEqual(parsed_files, [])
# check when passing an existing bytestring path
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_read_returns_file_list is already too long, could you move it a separate test case?

Misc/NEWS.d/next/Library/2017-09-07-12-50-28.bpo-31307.AVBiNY.rst Outdated
@@ -0,0 +1 @@
Allow use of bytes objects for arguments to configparser.ConfigParser.read.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add "Patch by Vincent Michel.".

Misc/NEWS.d/next/Library/2017-09-07-12-50-28.bpo-31307.AVBiNY.rst Outdated
@@ -0,0 +1 @@
Allow use of bytes objects for arguments to configparser.ConfigParser.read.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:meth:`configparser.ConfigParser.read`

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@vxgmichel
Copy link
Contributor Author

@berkerpeksag Thanks for the review. I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@merwok, @berkerpeksag: please review the changes made to this pull request.

@berkerpeksag berkerpeksag merged commit e314853 into python:master Nov 2, 2017
@berkerpeksag
Copy link
Member

Thanks!

@vxgmichel vxgmichel deleted the bpo-31307 branch November 2, 2017 12:53
@ambv
Copy link
Contributor

ambv commented Nov 2, 2017

Thanks! ✨ 🍰 ✨

embray pushed a commit to embray/cpython that referenced this pull request Nov 9, 2017
@vxgmichel @embray
bpo-31307: Make ConfigParser.read() accept bytes objects (pythonGH-3420)
a68756e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berkerpeksag berkerpeksag berkerpeksag approved these changes

@merwok merwok merwok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vxgmichel @bedevere-bot @berkerpeksag @ambv @merwok @the-knights-who-say-ni