pytime: include winsock2, so we can have a complete timeval type #3377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
reviewed
Sep 6, 2017
Python/pytime.c
Outdated
| @@ -1,6 +1,7 @@ | |||
| #include "Python.h" | |||
| #ifdef MS_WINDOWS | |||
| #include <windows.h> | |||
| #include <winsock2.h> | |||
There was a problem hiding this comment.
Would you mind to add a comment to explain why we need to import networking functions in pytime.c? :-) (To get the timeval structure)
benjaminp
force-pushed
the
benjamin-winsock2
branch
from
2965db0 to
ff0d110
Compare
pitrou
added a commit
to pitrou/cpython
that referenced
this pull request
Sep 6, 2017
…ype (python#3377)" This reverts commit 8338606, as it broke Windows builds.
pitrou
added a commit
to pitrou/cpython
that referenced
this pull request
Sep 6, 2017
…ype (python#3377)" (python#3383) This reverts commit 8338606, as it broke Windows builds.
GadgetSteve
pushed a commit
to GadgetSteve/cpython
that referenced
this pull request
Sep 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.