Skip to content
/ cpython Public
  • Rate limit · GitHub

    Access has been restricted

    You have triggered a rate limit.

    Please wait a few minutes before you try again;
    in some cases this may take up to an hour.

  • Notifications You must be signed in to change notification settings
  • Fork 31.2k
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-31330: Clarify that multiple new lines are reduced to one. #3272

Merged
merged 2 commits into from
Sep 7, 2017
Rate limit · GitHub

Access has been restricted

You have triggered a rate limit.

Please wait a few minutes before you try again;
in some cases this may take up to an hour.

Conversation

elenaoat
Copy link
Contributor

@elenaoat elenaoat commented Sep 3, 2017

As per http://bugs.python.org/issue31330. I've added a couple of sentences explaining the behaviour and providing the solution.

https://bugs.python.org/issue31330

including argument descriptions.
including argument descriptions. However, multiple new lines in epilog and
description are replaced with one. If you prefer to use multiple new lines,
add white space between the new line characters.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to mention epilog and description here. It sounds like all instances of adjacent newlines are turned into single newlines.

I would phrase the last sentence: "If you wish to preserve multiple blank lines, add spaces between the newlines.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added the requested changes.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I didn't expect the Spanish Inquisition!. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@miss-islington
Copy link
Contributor

🐍🍒⛏🤖 Thanks @elenaoat for the PR, and @bitdancer for merging it 🌮🎉.I'm working now to backport this PR to: 2.7, 3.6.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 7, 2017
… newlines. (pythonGH-3272)

Also provide a solution if the user wants to keep multiple blank lines.
(cherry picked from commit 397c467)
@bedevere-bot
Copy link

GH-3428 is a backport of this pull request to the 2.7 branch.

@miss-islington
Copy link
Contributor

🐍🍒⛏🤖 Thanks @elenaoat for the PR, and @bitdancer for merging it 🌮🎉.I'm working now to backport this PR to: 3.6.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 7, 2017
… newlines. (pythonGH-3272)

Also provide a solution if the user wants to keep multiple blank lines.
(cherry picked from commit 397c467)
@bedevere-bot
Copy link

GH-3429 is a backport of this pull request to the 3.6 branch.

bitdancer pushed a commit that referenced this pull request Sep 7, 2017
… newlines. (GH-3272) (GH-3428)

Also provide a solution if the user wants to keep multiple blank lines.
(cherry picked from commit 397c467)
bitdancer pushed a commit that referenced this pull request Sep 7, 2017
… newlines. (GH-3272) (GH-3429)

Also provide a solution if the user wants to keep multiple blank lines.
(cherry picked from commit 397c467)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rate limit · GitHub

Access has been restricted

You have triggered a rate limit.

Please wait a few minutes before you try again;
in some cases this may take up to an hour.

6 participants