bpo-47212: Improve error messages for un-parenthesized generator expressions

[MatthieuDartiailh]

Fixes the minor inconsistencies noticed in bpo-47212. Those could be backported to 3.10 but I have no idea what is the policy in that respect.

ping @pablogsal @lysnikolaou

https://bugs.python.org/issue47212

[pablogsal]

@MatthieuDartiailh Can you add/modify some test cases?

[pablogsal]

Those could be backported to 3.10

Yeah, definitely we can backport these.

[MatthieuDartiailh]

Sure if I can find them.

[MatthieuDartiailh]

The tests in test_syntax.py do not track the start and end position of the SyntaxError, so I am not sure where to add a test. For the indentation error I found where to add it.

[pablogsal]

The tests in test_syntax.py do not track the start and end position of the SyntaxError, so I am not sure where to add a test. For the indentation error I found where to add it.

I think you can add a case to test_exceptions.py::testSyntaxErrorOffset or a similar test in that file.

[MatthieuDartiailh]

I tried to add some tests but did not get a chance to test locally.

[MatthieuDartiailh]

check in test_exceptions does not check the end offset should I add a new method doing that ?

[pablogsal]

Ah, that is because it precedes the changes I did in 3.10. Yeah, please, if you don't mind add a check for the end range. Thanks 🙏

[MatthieuDartiailh]

Tests are now passing. What should I do exactly for bedevere/news ?

[AlexWaygood]

Tests are now passing. What should I do exactly for bedevere/news ?

You can use https://blurb-it.herokuapp.com/ to add a NEWS entry :)

[MatthieuDartiailh]

Thanks @AlexWaygood hopefully I did it right

[miss-islington]

Thanks @MatthieuDartiailh for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

[miss-islington]

Sorry, @MatthieuDartiailh and @pablogsal, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker aa0f056a00c4bcaef83d729e042359ddae903382 3.10

[pablogsal]

@MatthieuDartiailh Can you do the backport using the cherry_picker utility? Check the instructions in this comment:

#32302 (comment)

[MatthieuDartiailh]

@pablogsal The cherry pick will be really messy because action_helpers.c does not exist on 3.10. Not sure it is worth backporting then.

[pablogsal]

@pablogsal The cherry pick will be really messy because action_helpers.c does not exist on 3.10. Not sure it is worth backporting then.

The code for action_helpers.c is on pegen.c in 3.10. In the main branch was just split for better maintainability.

Don't worry if you find it too hard, I can cherry pick myself if you don't want to do it :)

[MatthieuDartiailh]

Bacport is at #32334. Hopefully I got it right

[bedevere-bot]

GH-32334 is a backport of this pull request to the 3.10 branch.