bpo-30737: Update link to the Devguide #3228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugzPDX
force-pushed
the
fix-devguide-url
branch
from
e92577e to
94497ba
Compare
Mariatta
requested changes
Aug 28, 2017
Doc/README.rst
Outdated
| @@ -7,7 +7,7 @@ available <https://docs.python.org/dev/download.html>`_. | |||
|
|
|||
| Documentation on authoring Python documentation, including information about | |||
| both style and markup, is available in the "`Documenting Python | |||
| <https://docs.python.org/devguide/documenting.html>`_" chapter of the | |||
| <https://devguide.python.org/documenting.html>`_" chapter of the | |||
There was a problem hiding this comment.
This can be dev.guide.python.org/documenting/ (without the .html)
Doc/using/unix.rst
Outdated
| @@ -67,7 +67,7 @@ Building Python | |||
| If you want to compile CPython yourself, first thing you should do is get the | |||
| `source <https://www.python.org/downloads/source/>`_. You can download either the | |||
| latest release's source or just grab a fresh `clone | |||
| <https://docs.python.org/devguide/setup.html#getting-the-source-code>`_. (If you want | |||
| <https://devguide.python.org/setup.html#getting-the-source-code>`_. (If you want | |||
There was a problem hiding this comment.
The url can be:
https://devguide.python.org/setup/#getting-the-source-code
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Mariatta
changed the title
|
I changed the bpo number to the correct one :) |
|
Commits unrelated to this PR are showing up after your merge, I suspect you need to rebase to avoid that? |
The Devguide has a new url so all the old links are updated.
Fix url endings by removing .html and update urls to use https.
|
Yep! I pulled in everyone's commits. Working on it.
…On Tue, Aug 29, 2017 at 9:31 PM, Gregory P. Smith ***@***.***> wrote:
Commits unrelated to this PR are showing up after your merge, I *suspect*
you need to rebase to avoid that?
https://devguide.python.org/gitbootcamp/#syncing-with-upstream
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3228 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AFNrlxpDww2rBUWOSsHwDoM4cVRw0ytOks5sdOW0gaJpZM4PExfi>
.
|
bugzPDX
force-pushed
the
fix-devguide-url
branch
from
235776a to
b96807c
Compare
Mariatta
approved these changes
Aug 30, 2017
|
The changes look good now, and no longer showing diffs of unrelated commit. |
|
Thanks @bugzPDX and congrats on your first contribution to CPython 🌮 |
jimmylai
pushed a commit
to jimmylai/cpython
that referenced
this pull request
Sep 4, 2017
* 'master' of https://github.com/python/cpython: (601 commits) remove check for bug last seem in Solaris 9 (python#3285) Change code owners for hashlib and ssl to the crypto team (python#3284) bpo-31281: Fix pathlib.Path incompatibility in fileinput (pythongh-3208) remove autoconf check for select() (python#3283) remove configure check for 'volatile' (python#3281) Add missing _sha3 module to Setup.dist (python#2395) bpo-12383: Also ignore __PYVENV_LAUNCHER__ (python#3278) bpo-9146: add the missing NEWS entry. (python#3275) Fix a c.f.as_completed() refleak previously introduced in bpo-27144 (python#3270) bpo-31185: Fixed miscellaneous errors in asyncio speedup module. (python#3076) remove a redundant lower in urllib.parse.urlsplit (python#3008) bpo-31323: Fix reference leak in test_ssl (python#3263) bpo-31250, test_asyncio: fix EventLoopTestsMixin.tearDown() (python#3264) bpo-31326: ProcessPoolExecutor waits for the call queue thread (python#3265) bpo-27144: concurrent.futures as_complete and map iterators do not keep reference to returned object (python#1560) bpo-31250, test_asyncio: fix dangling threads (python#3252) bpo-31217: Fix regrtest -R for small integer (python#3260) bpo-30096: Use ABC in abc reference examples (python#1220) bpo-30737: Update DevGuide links to new URL (pythonGH-3228) [Trivial] Remove now redundant assert (python#3245) ...
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 6, 2017
Update old devguide links from https://docs.python.org/devguide to https://devguide.python.org (cherry picked from commit 384899d)
|
GH-3390 is a backport of this pull request to the 3.6 branch. |
Mariatta
pushed a commit
that referenced
this pull request
Sep 6, 2017
Update old devguide links from https://docs.python.org/devguide to https://devguide.python.org (cherry picked from commit 384899d)
GadgetSteve
pushed a commit
to GadgetSteve/cpython
that referenced
this pull request
Sep 10, 2017
Update old devguide links from https://docs.python.org/devguide to https://devguide.python.org
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Devguide has a new url so all the old links are updated.
https://bugs.python.org/issue30737