Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-70979: Fix runpy.run_path parameter name in docs #32265

Merged
merged 2 commits into from
Apr 15, 2022

Conversation

JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra commented Apr 2, 2022

Noticed while reviewing GH-30729.

It's been like this since at least 3.9.
3.9:

def run_path(path_name, init_globals=None, run_name=None):

main:
def run_path(path_name, init_globals=None, run_name=None):

#70979

https://bugs.python.org/issue26792

@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Apr 2, 2022
@JelleZijlstra JelleZijlstra self-assigned this Apr 2, 2022
@JelleZijlstra JelleZijlstra added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Apr 14, 2022
@JelleZijlstra JelleZijlstra changed the title bpo-26792: Fix runpy.run_path parameter name in docs gh-70979: Fix runpy.run_path parameter name in docs Apr 14, 2022
@JelleZijlstra
Copy link
Member Author

@erlend-aasland would you mind reviewing this small change?

@erlend-aasland erlend-aasland self-requested a review April 14, 2022 06:56
@JelleZijlstra JelleZijlstra merged commit f1e989b into main Apr 15, 2022
@JelleZijlstra JelleZijlstra deleted the JelleZijlstra-patch-1 branch April 15, 2022 01:07
@miss-islington
Copy link
Contributor

Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 15, 2022
…2265)

Noticed while reviewing pythonGH-30729.
(cherry picked from commit f1e989b)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@bedevere-bot
Copy link

GH-91552 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Apr 15, 2022
@bedevere-bot
Copy link

GH-91553 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Apr 15, 2022
miss-islington added a commit that referenced this pull request Apr 15, 2022
Noticed while reviewing GH-30729.
(cherry picked from commit f1e989b)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
miss-islington added a commit that referenced this pull request Apr 15, 2022
Noticed while reviewing GH-30729.
(cherry picked from commit f1e989b)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
…2265)

Noticed while reviewing pythonGH-30729.
(cherry picked from commit f1e989b)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants