Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-47180: Remove unnecessary registration of weakref.WeakSet as a subtype of _collections_abc.Set #32211

Merged
merged 1 commit into from
Mar 31, 2022
Merged

bpo-47180: Remove unnecessary registration of weakref.WeakSet as a subtype of _collections_abc.Set #32211

merged 1 commit into from
Mar 31, 2022

Conversation

geryogam
Copy link
Contributor

@geryogam geryogam commented Mar 31, 2022 •
edited by bedevere-bot
Loading

Registering weakref.WeakSet as a subtype of _collections_abc.MutableSet implies that it is also a subtype of _collections_abc.Set since _collections_abc.MutableSet is a subtype of _collections_abc.Set and the subtype relation is transitive.

https://bugs.python.org/issue47180

@geryogam geryogam changed the title Remove unnecessary registration of weakref.WeakSet as a subtype of _collections_abc.Set bpo-47180: Remove unnecessary registration of weakref.WeakSet as a subtype of _collections_abc.Set Mar 31, 2022
@rhettinger rhettinger self-assigned this Mar 31, 2022
@rhettinger rhettinger merged commit 5458b7e into python:main Mar 31, 2022
@geryogam geryogam deleted the patch-31 branch April 1, 2022 06:18
@geryogam
Copy link
Contributor Author

geryogam commented Apr 1, 2022

Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rhettinger rhettinger

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@geryogam @rhettinger @the-knights-who-say-ni @bedevere-bot