Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-42658: Using LCMapStringEx in ntpath.normcase #32010

Merged
merged 17 commits into from
Jun 6, 2022
Merged

bpo-42658: Using LCMapStringEx in ntpath.normcase #32010

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
060cd71
Add _winapi.LCMapStringEx
aisk Mar 20, 2022
6ecbc48
Using _winapi.LCMapStringEx in ntpath.normcase
aisk Mar 20, 2022
c1429b9
📜🤖 Added by blurb_it.
blurb-it[bot] Mar 20, 2022
81be381
Changes from review
aisk Mar 21, 2022
6108d20
Update for comments
aisk Mar 21, 2022
3b4a5cb
Update for review and fix tests
aisk Mar 22, 2022
ef66941
Update by review comment
aisk Mar 23, 2022
6c0366b
Update for review comments
aisk Mar 25, 2022
6c6f2e2
fix news
aisk Mar 25, 2022
15749b8
Remove constants which can not been used
aisk Mar 26, 2022
7b2c62c
Fix ntpath_tests on non Windows systems
aisk Mar 26, 2022
a89adc0
Update news
aisk Mar 31, 2022
4119cc2
Skip test on block leaks on windows
aisk Mar 31, 2022
8a63de2
Fix news
aisk Mar 31, 2022
6789cd9
Revert the test modify
aisk Apr 9, 2022
d430371
update news
aisk Jun 4, 2022
7e0dcf8
update clinic for _winapi
aisk Jun 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Skip test on block leaks on windows
  • Loading branch information
@aisk
aisk committed Jun 4, 2022
commit 4119cc2a86d0326a6b2c82a9358e5547fa6866db
6 changes: 5 additions & 1 deletion Lib/test/test_embed.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1705,7 +1705,11 @@ def test_no_memleak(self):
blocks = int(match.group(2))
with self.subTest(frozen_modules=flag, stmt=stmt):
self.assertEqual(refs, 0, out)
self.assertEqual(blocks, 0, out)
if not MS_WINDOWS:
self.assertEqual(blocks, 0, out)
else:
# bpo-42658: on Windows, Python still leaks 1 memory block at exit
self.assertEqual(blocks, 1, out)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found that there is a block leak here, but I think this is not related to this issue (and have no idea how to fix it 😥). Just skipped it for now, but don't know if it's appropriate to do so.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not appropriate. If it only occurs in this PR, then we need to count references carefully and find out where it's leaking. If it happens in others as well, then we should make sure someone's looking into it and can probably merge anyway.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it.



class StdPrinterTests(EmbeddingTestsMixin, unittest.TestCase):
Expand Down