Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-31234: test_threaded_import: fix test_side_effect_import() #3189

Merged
merged 1 commit into from
Aug 22, 2017
Merged

bpo-31234: test_threaded_import: fix test_side_effect_import() #3189

merged 1 commit into from
Aug 22, 2017

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Aug 22, 2017

  • Don't leak the module into sys.modules
  • Avoid dangling thread

https://bugs.python.org/issue31234

* Don't leak the module into sys.modules
* Avoid dangling thread
@vstinner vstinner merged commit 41bbd82 into python:master Aug 22, 2017
@vstinner vstinner deleted the test_threaded_import branch August 22, 2017 16:05
GadgetSteve pushed a commit to GadgetSteve/cpython that referenced this pull request Sep 10, 2017
…n#3189)

* Don't leak the module into sys.modules
* Avoid dangling thread
@miss-islington
Copy link
Contributor

Thanks @Haypo for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 13, 2017
…ythonGH-3189)

* Don't leak the module into sys.modules
* Avoid dangling thread
(cherry picked from commit 41bbd82)
@bedevere-bot
Copy link

GH-3537 is a backport of this pull request to the 3.6 branch.

vstinner pushed a commit that referenced this pull request Sep 13, 2017
…H-3189) (#3537)

* Don't leak the module into sys.modules
* Avoid dangling thread
(cherry picked from commit 41bbd82)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants