gh-91099: fix[imaplib]: call Exception with string instance#31823
Open
spaceone wants to merge 2 commits intopython:mainfrom
Open
gh-91099: fix[imaplib]: call Exception with string instance#31823spaceone wants to merge 2 commits intopython:mainfrom
spaceone wants to merge 2 commits intopython:mainfrom
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Member
|
@spaceone Could you sign the new CLA by clicking |
Author
I tried but get a white screen with |
Member
|
No worries, your click was accepted. The displayed error is a known although yet untracked problem. |
Member
|
@python/email-team |
Adjust the behavior similar to `authenticate()` where self.error is
called with a str() instance.
Especially for Python3 with strict bytes mode (-bb) this is helpful and
prevents:
Traceback (most recent call last):
in "<stdin>"
self.login(email, password)
File "/usr/lib/python3.7/imaplib.py", line 598, in login
raise self.error(dat[-1])
imaplib.error: <exception str() failed>
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
in "<stdin>"
str(exc)
BytesWarning: str() on a bytes instance
300787f to
4b7fa1c
Compare
Author
|
rebased :-) |
4b7fa1c to
0a9dc07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjust the behavior of
login()similar toauthenticate()whereself.erroris called with astrinstance.Especially for Python3 with strict bytes mode (-bb) this is helpful and prevents:
https://bugs.python.org/issue46943