bpo-30983: [gdb] Fix py-bt, etc. for non-debug shared builds #3153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
reviewed
Aug 21, 2017
Tools/gdb/libpython.py
Outdated
| def is_evalframeex(self): | ||
| '''Is this a PyEval_EvalFrameEx frame?''' | ||
| if self._gdbframe.name() == 'PyEval_EvalFrameEx': | ||
| def is_evalframedefault(self): |
There was a problem hiding this comment.
I suggest to rename the method to is_evalframe().
Tools/gdb/libpython.py
Outdated
| if self._gdbframe.name() == 'PyEval_EvalFrameEx': | ||
| def is_evalframedefault(self): | ||
| '''Is this a _PyEval_EvalFrameDefault frame?''' | ||
| if self._gdbframe.name() == '_PyEval_EvalFrameDefault': |
There was a problem hiding this comment.
Please put '_PyEval_EvalFrameDefault' in a constant at the top of the file, so if someone really needs to catch PyEval_EvalFrameEx(), it will be easier to update python-gdb at runtime.
PEP 523 introduced _PyEval_EvalFrameDefault which inlines PyEval_EvalFrameEx on non-debug shared builds. This breaks the ability to use py-bt, py-up, and a few other Python-specific gdb integrations. This patch fixes the problem by only looking for _PyEval_EvalFrameDefault frames. test_gdb passes on both a debug and a non-debug build. Original patch by Bruno "Polaco" Penteado.
vstinner
approved these changes
Aug 21, 2017
ambv
added a commit
to ambv/cpython
that referenced
this pull request
Aug 22, 2017
…ythonGH-3153) PEP 523 introduced _PyEval_EvalFrameDefault which inlines PyEval_EvalFrameEx on non-debug shared builds. This breaks the ability to use py-bt, py-up, and a few other Python-specific gdb integrations. This patch fixes the problem by only looking for _PyEval_EvalFrameDefault frames. test_gdb passes on both a debug and a non-debug build. Original patch by Bruno "Polaco" Penteado. (cherry picked from commit 5fe59f8)
ambv
added a commit
that referenced
this pull request
Aug 22, 2017
…H-3153) (#3192) PEP 523 introduced _PyEval_EvalFrameDefault which inlines PyEval_EvalFrameEx on non-debug shared builds. This breaks the ability to use py-bt, py-up, and a few other Python-specific gdb integrations. This patch fixes the problem by only looking for _PyEval_EvalFrameDefault frames. test_gdb passes on both a debug and a non-debug build. Original patch by Bruno "Polaco" Penteado. (cherry picked from commit 5fe59f8)
GadgetSteve
pushed a commit
to GadgetSteve/cpython
that referenced
this pull request
Sep 10, 2017
…3153) PEP 523 introduced _PyEval_EvalFrameDefault which inlines PyEval_EvalFrameEx on non-debug shared builds. This breaks the ability to use py-bt, py-up, and a few other Python-specific gdb integrations. This patch fixes the problem by only looking for _PyEval_EvalFrameDefault frames. test_gdb passes on both a debug and a non-debug build. Original patch by Bruno "Polaco" Penteado.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PEP 523 introduced _PyEval_EvalFrameDefault which inlines PyEval_EvalFrameEx on
non-debug shared builds. This breaks the ability to use py-bt, py-up, and
a few other Python-specific gdb integrations.
This patch fixes the problem by only looking for _PyEval_EvalFrameDefault
frames.
test_gdb passes on both a debug and a non-debug build.
Original patch by Bruno "Polaco" Penteado.
https://bugs.python.org/issue30983