Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-31238: pydoc ServerThread.stop() now joins itself #3151

Merged
merged 3 commits into from
Aug 21, 2017
Merged

bpo-31238: pydoc ServerThread.stop() now joins itself #3151

merged 3 commits into from
Aug 21, 2017

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Aug 18, 2017 •
edited by bedevere-bot
Loading

ServerThread.stop() now joins itself to wait until
DocServer.serve_until_quit() completes and then explicitly sets
its docserver attribute to None to break a reference cycle.

https://bugs.python.org/issue31238

@vstinner
bpo-31238: pydoc ServerThread.stop() now joins itself
6e32c53 
ServerThread.stop() now joins itself to wait until
DocServer.serve_until_quit() completes and then explicitly sets
its docserver attribute to None to break a reference cycle.
@vstinner
Copy link
Member Author

cc @JulienPalard

@vstinner vstinner requested a review from vadmium August 18, 2017 23:52
@pitrou
Copy link
Member

pitrou commented Aug 21, 2017

Looks good to me.

@vstinner vstinner merged commit 4cab2cd into python:master Aug 21, 2017
@vstinner vstinner deleted the pydoc_join branch August 21, 2017 21:24
@vstinner
Copy link
Member Author

Ok, thanks for the review @pitrou.

@vstinner vstinner mentioned this pull request Aug 22, 2017
Closed
GadgetSteve pushed a commit to GadgetSteve/cpython that referenced this pull request Sep 10, 2017
@vstinner @GadgetSteve
bpo-31238: pydoc ServerThread.stop() now joins itself (python#3151)
8745c30 
* bpo-31238: pydoc ServerThread.stop() now joins itself

ServerThread.stop() now joins itself to wait until
DocServer.serve_until_quit() completes and then explicitly sets
its docserver attribute to None to break a reference cycle.

* Add NEWS.d entry
vstinner added a commit that referenced this pull request Jun 1, 2018
@vstinner
bpo-31238: pydoc ServerThread.stop() now joins itself (GH-3151) (GH-7324
f329743 
)

ServerThread.stop() now joins itself to wait until
DocServer.serve_until_quit() completes and then explicitly sets
its docserver attribute to None to break a reference cycle.

(cherry picked from commit 4cab2cd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadmium vadmium Awaiting requested review from vadmium

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vstinner @pitrou @Mariatta @the-knights-who-say-ni @bedevere-bot