[3.10] bpo-46333: Honor module parameter in ForwardRef (GH-30536)
#31379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `module` parameter carries semantic information about the forward ref. Forward refs are different if they refer to different module even if they have the same name. This affects the `__eq__`, `__repr__` and `__hash__` methods. Co-authored-by: Andreas Hangauer <andreas.hangauer@siemens.com> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com> Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com> (cherry picked from commit 6e7b813) Co-authored-by: aha79 <34090357+aha79@users.noreply.github.com>
miss-islington
requested review from
gvanrossum and
Fidget-Spinner
as code owners
|
@aha79 and @JelleZijlstra: Status check is done, and it's a success ✅ . |
JelleZijlstra
approved these changes
Feb 17, 2022
|
@miss-islington: Status check is done, and it's a success ✅ . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
moduleparameter carries semantic information about the forward ref.Forward refs are different if they refer to different module even if they
have the same name. This affects the
__eq__,__repr__and__hash__methods.Co-authored-by: Andreas Hangauer andreas.hangauer@siemens.com
Co-authored-by: Alex Waygood Alex.Waygood@Gmail.com
Co-authored-by: Ken Jin 28750310+Fidget-Spinner@users.noreply.github.com
(cherry picked from commit 6e7b813)
Co-authored-by: aha79 34090357+aha79@users.noreply.github.com
https://bugs.python.org/issue46333
Automerge-Triggered-By: GH:JelleZijlstra