Skip to content

[3.10] bpo-46433: _PyType_GetModuleByDef: handle static types in MRO (GH-30696) #31262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 11, 2022
Merged

[3.10] bpo-46433: _PyType_GetModuleByDef: handle static types in MRO (GH-30696) #31262

merged 2 commits into from
Feb 11, 2022

Conversation

encukou
Copy link
Member

@encukou encukou commented Feb 10, 2022 •
edited by bedevere-bot
Loading

(cherry picked from commit 0ef0853)

https://bugs.python.org/issue46433

@encukou encukou requested a review from markshannon as a code owner February 10, 2022 16:37
@encukou encukou changed the title bpo-46433: _PyType_GetModuleByDef: handle static types in MRO (GH-30696) [3.10] bpo-46433: _PyType_GetModuleByDef: handle static types in MRO (GH-30696) Feb 10, 2022
@bedevere-bot bedevere-bot mentioned this pull request Feb 10, 2022
Merged
vstinner
vstinner approved these changes Feb 10, 2022
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

There was just a minor change between while and for in the main branch, but with this change, 3.10 and main use "for", so it's better!

erlend-aasland
erlend-aasland requested changes Feb 10, 2022
View reviewed changes
erlend-aasland
erlend-aasland approved these changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm

@encukou encukou merged commit 8b8673f into python:3.10 Feb 11, 2022
@encukou
Copy link
Member Author

encukou commented Feb 11, 2022

Thanks for the review!

@encukou encukou deleted the backport-0ef0853-3.10 branch February 11, 2022 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@encukou @vstinner @erlend-aasland @the-knights-who-say-ni @bedevere-bot