Skip to content

bpo-46072: Right justify numeric columns in stats summary script. #31234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2022
Merged

bpo-46072: Right justify numeric columns in stats summary script. #31234

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 17 additions & 8 deletions Tools/scripts/summarize_stats.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def print_specialization_stats(name, family_stats, defines):
label = label[0].upper() + label[1:]
val = family_stats.get(key, 0)
rows.append((label, val, f"{100*val/total_attempts:0.1f}%"))
emit_table(("", "Count", "Ratio"), rows)
emit_table(("", "Count:", "Ratio:"), rows)
total_failures = family_stats.get("specialization.failure", 0)
failure_kinds = [ 0 ] * 30
for key in family_stats:
Expand All @@ -71,7 +71,7 @@ def print_specialization_stats(name, family_stats, defines):
if not value:
continue
rows.append((kind_to_text(index, defines, name), value, f"{100*value/total_failures:0.1f}%"))
emit_table(("Failure kind", "Count", "Ratio"), rows)
emit_table(("Failure kind", "Count:", "Ratio:"), rows)

def gather_stats():
stats = collections.Counter()
Expand Down Expand Up @@ -174,8 +174,17 @@ def __exit__(*args):

def emit_table(header, rows):
width = len(header)
print("|", " | ".join(header), "|")
print("|", " | ".join(["---"]*width), "|")
header_line = "|"
under_line = "|"
for item in header:
under = "---"
if item.endswith(":"):
item = item[:-1]
under += ":"
header_line += item + " | "
under_line += under + "|"
print(header_line)
print(under_line)
for row in rows:
if width is not None and len(row) != width:
raise ValueError("Wrong number of elements in row '" + str(rows) + "'")
Expand Down Expand Up @@ -204,7 +213,7 @@ def emit_execution_counts(opcode_stats, total):
rows.append((name, count, f"{100*count/total:0.1f}%",
f"{100*cumulative/total:0.1f}%", miss))
emit_table(
("Name", "Count", "Self", "Cumulative", "Miss ratio"),
("Name", "Count:", "Self:", "Cumulative:", "Miss ratio:"),
rows
)

Expand All @@ -221,7 +230,7 @@ def emit_specialization_stats(opcode_stats):
def emit_specialization_overview(opcode_stats, total):
basic, not_specialized, specialized = categorized_counts(opcode_stats)
with Section("Specialization effectiveness"):
emit_table(("Instructions", "Count", "Ratio"), (
emit_table(("Instructions", "Count:", "Ratio:"), (
("Basic", basic, f"{basic*100/total:0.1f}%"),
("Not specialized", not_specialized, f"{not_specialized*100/total:0.1f}%"),
("Specialized", specialized, f"{specialized*100/total:0.1f}%"),
Expand All @@ -240,7 +249,7 @@ def emit_call_stats(stats):
for key, value in stats.items():
if key.startswith("Frame"):
rows.append((key, value, f"{100*value/total:0.1f}%"))
emit_table(("", "Count", "Ratio"), rows)
emit_table(("", "Count:", "Ratio:"), rows)

def emit_object_stats(stats):
with Section("Object stats", summary="allocations, frees and dict materializatons"):
Expand All @@ -255,7 +264,7 @@ def emit_object_stats(stats):
label = key[6:].strip()
label = label[0].upper() + label[1:]
rows.append((label, value, materialize))
emit_table(("", "Count", "Ratio"), rows)
emit_table(("", "Count:", "Ratio:"), rows)

def main():
stats = gather_stats()
Expand Down