gh-90808: add more examples to test_sched.test_priority
#31144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@serhiy-storchaka you are the top committer to this module, maybe you would be interested in taking a look? 🙂 |
MaxwellDupre
approved these changes
Jun 17, 2022
Contributor
MaxwellDupre
left a comment
MaxwellDupre
left a comment
There was a problem hiding this comment.
Nice piece of code, does whats asked/suggested.
Member
Author
|
@JelleZijlstra would you have some free time to take a look? This PR only adds more test cases to some exiting test function 🙂 |
JelleZijlstra
changed the title
test_sched.test_prioritytest_sched.test_priority
JelleZijlstra
approved these changes
Sep 21, 2022
JelleZijlstra
added
needs backport to 3.10
Contributor
|
Thanks @sobolevn for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
|
GH-96981 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 21, 2022
…onGH-31144) (cherry picked from commit 57463d4) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
|
GH-96982 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 21, 2022
…onGH-31144) (cherry picked from commit 57463d4) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington
added a commit
that referenced
this pull request
Sep 21, 2022
(cherry picked from commit 57463d4) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington
added a commit
that referenced
this pull request
Sep 21, 2022
(cherry picked from commit 57463d4) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue46650
priorityinsched.scheduleris not sufficiently tested #90808