-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-30947: Update libexpat from 2.2.1 to 2.2.3 #3106
Conversation
The CI checks failed because of patchcheck: see https://bugs.python.org/issue31221 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems sane. i'm not reviewing the changed to expat itself, just that it appears to be a rational update. you might also consider checking in your cpython_rebuild_expat_dir.sh script that you've attached to the bpo issue.
@gpshead: "you might also consider checking in your cpython_rebuild_expat_dir.sh script that you've attached to the bpo issue." My script is crappy: the version is hardcoded and uses the libexpat tag format, it requires a libexpat repository with an hardcoded path on my disk, etc. :-) I'm not interested to include it right now. |
Oh, compilation fails on Travis CI at:
|
* bpo-30947: Update libexpat from 2.2.1 to 2.2.3 * Add NEWS entry * Add new loadlibrary.c * expat_external.h: restore include "pyexpatns.h" * PCbuild: add expat/loadlibrary.c * Define XML_POOR_ENTROPY to compile expat Python 2.7 backport: add expat/loadlibrary.c to PC/VS9.0/ project files (_elementtree and pyexpat). (cherry picked from commit 93d0cb5)
https://bugs.python.org/issue30947