Skip to content

bpo-30983: Revert changes which broke most buildbots #3100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 16, 2017
Merged

bpo-30983: Revert changes which broke most buildbots #3100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ec3975
Revert "Add Bruno Penteado to ACKS (#3091)"
vstinner Aug 16, 2017
43cab67
Revert "bpo-30983: eval frame rename in pep 0523 broke gdb's python e…
vstinner Aug 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Misc/ACKS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1184,7 +1184,6 @@ Berker Peksag
Andreas Pelme
Steven Pemberton
Bo Peng
Bruno "Polaco" Penteado
Santiago Peresón
George Peristerakis
Thomas Perl
Expand Down
6 changes: 2 additions & 4 deletions Tools/gdb/libpython.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1502,10 +1502,8 @@ def is_python_frame(self):
return False

def is_evalframeex(self):
'''Is this a PyEval_EvalFrameEx or _PyEval_EvalFrameDefault (PEP 0523)
frame?'''
if self._gdbframe.name() in ('PyEval_EvalFrameEx',
'_PyEval_EvalFrameDefault'):
'''Is this a PyEval_EvalFrameEx frame?'''
if self._gdbframe.name() == 'PyEval_EvalFrameEx':
'''
I believe we also need to filter on the inline
struct frame_id.inline_depth, only regarding frames with
Expand Down