bpo-46285: Add command-line option -p/--protocol to module http.server #30999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the the PR! Let’s merge this one after the bug fix to the same module. |
JelleZijlstra
approved these changes
Jan 29, 2022
geryogam
force-pushed
the
patch-26
branch
3 times, most recently
from
5323621 to
f5e0dc4
Compare
merwok
reviewed
Feb 3, 2022
|
Please avoid rebases and force-pushes for CPython, github does not have a good experience for reviewers. |
merwok
reviewed
Feb 4, 2022
JelleZijlstra
approved these changes
May 2, 2022
orsenthil
approved these changes
May 2, 2022
There was a problem hiding this comment.
LGTM.
I had a brief hesitancy for exposing this protocol version via flag as the support is not comprehensive. I am pretty sure we are missing many features.
But given that class supports .protocol_version as a attribute, exposing it via a command line flag is alright.
|
Thanks @merwok, @JelleZijlstra, and @orsenthil for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add command-line option
-p/--protocolto modulehttp.serverwhich specifies the HTTP version to which the server is conformant (HTTP/1.1 servers can now be run from the command-line interface of modulehttp.server):https://bugs.python.org/issue46285