Skip to content

[3.6] bpo-30983: eval frame rename in pep 0523 broke gdb's python extension (GH-2803) #3090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ambv merged 1 commit into from
Aug 14, 2017
Merged

[3.6] bpo-30983: eval frame rename in pep 0523 broke gdb's python extension (GH-2803) #3090

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Misc/NEWS.d/next/Tools-Demos/2017-08-14-15-37-38.bpo-30983.A7UzX8.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
With PEP 523, gdb's Python integration stopped working properly for frames
using the ``_PyEval_EvalFrameDefault`` function. Affected functionality
included `py-list` and `py-bt`. This is now fixed. Patch by Bruno "Polaco"
Penteado.
6 changes: 4 additions & 2 deletions Tools/gdb/libpython.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1502,8 +1502,10 @@ def is_python_frame(self):
return False

def is_evalframeex(self):
'''Is this a PyEval_EvalFrameEx frame?'''
if self._gdbframe.name() == 'PyEval_EvalFrameEx':
'''Is this a PyEval_EvalFrameEx or _PyEval_EvalFrameDefault (PEP 0523)
frame?'''
if self._gdbframe.name() in ('PyEval_EvalFrameEx',
'_PyEval_EvalFrameDefault'):
'''
I believe we also need to filter on the inline
struct frame_id.inline_depth, only regarding frames with
Expand Down