Update generated files list and add diff=generated attribute
#30745
Conversation
+ Include/internal/pycore_ast_state.h + Lib/keyword.py + Parser/parser.c + Python/Python-ast.c + Python/stdlib_module_names.h + Tools/peg_generator/pegen/grammar_parser.py
|
FYI @isidentical, I added some of the missing generated files, mostly related to the parser. |
|
|
erlend-aasland
changed the title
diff=generated attributediff=generated attribute
|
Added |
|
cc. @arhadthedev (I can't directly request your review on the PR) |
There was a problem hiding this comment.
Thanks for the PR @erlend-aasland, LGTM. Assuming this includes everything from our make regen-all targets
There was a problem hiding this comment.
Looks good to me, I have no objection on who successfully pushes a solution to a problem.
By the way, what does Edit: I found the answer in python/core-workflow#425.diff=generated do? Google returned nothing relevant for git diff generated; grepping the repository gives lots of clutter as well.
I went through the Makefile twice, but I may have overlooked something. Feel free to double check 🕵🏻 |
|
IMO, I don't think it is worth the hassle to backport this. Cry out if you disagree. |
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
@erlend-aasland: Status check is done, and it's a success ✅ . |
As a side effect, the list of generated files is relocated after the language aware diff settings.
Closes python/core-workflow#425
Automerge-Triggered-By: GH:zware