Skip to content

bpo-46437: remove useless hasattr from test_typing #30704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 19, 2022
Merged

bpo-46437: remove useless hasattr from test_typing #30704

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43b0d8e
bpo-46437: remove useless `hasattr` from `test_typing`
sobolevn Jan 19, 2022
c3d0c2e
Update test_typing.py
sobolevn Jan 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions Lib/test/test_typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3513,11 +3513,10 @@ def test_container(self):
self.assertNotIsInstance(42, typing.Container)

def test_collection(self):
if hasattr(typing, 'Collection'):
self.assertIsInstance(tuple(), typing.Collection)
self.assertIsInstance(frozenset(), typing.Collection)
self.assertIsSubclass(dict, typing.Collection)
self.assertNotIsInstance(42, typing.Collection)
self.assertIsInstance(tuple(), typing.Collection)
self.assertIsInstance(frozenset(), typing.Collection)
self.assertIsSubclass(dict, typing.Collection)
self.assertNotIsInstance(42, typing.Collection)

def test_abstractset(self):
self.assertIsInstance(set(), typing.AbstractSet)
Expand Down Expand Up @@ -5130,8 +5129,9 @@ def test_all(self):
self.assertIn('ValuesView', a)
self.assertIn('cast', a)
self.assertIn('overload', a)
if hasattr(contextlib, 'AbstractContextManager'):
self.assertIn('ContextManager', a)
# Context managers.
self.assertIn('ContextManager', a)
self.assertIn('AsyncContextManager', a)
# Check that io and re are not exported.
self.assertNotIn('io', a)
self.assertNotIn('re', a)
Expand All @@ -5145,8 +5145,6 @@ def test_all(self):
self.assertIn('SupportsComplex', a)

def test_all_exported_names(self):
import typing

actual_all = set(typing.__all__)
computed_all = {
k for k, v in vars(typing).items()
Expand Down