Skip to content

Mark all clinic headers as generated #30679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 19, 2022
Merged

Mark all clinic headers as generated #30679

merged 2 commits into from
Jan 19, 2022

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jan 19, 2022 •
edited by miss-islington
Loading

Automerge-Triggered-By: GH:zware

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Jan 19, 2022

The current pattern fails to catch Modules/_sqlite/clinic/*.h

@erlend-aasland erlend-aasland changed the title Mark _all_ clinic headers as generated Mark all clinic headers as generated Jan 19, 2022
JelleZijlstra
JelleZijlstra reviewed Jan 19, 2022
View reviewed changes
@JelleZijlstra
Update .gitattributes
3076541 
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@erlend-aasland erlend-aasland requested a review from zware January 19, 2022 12:48
@miss-islington miss-islington merged commit 71734d0 into python:main Jan 19, 2022
@erlend-aasland erlend-aasland deleted the git-clinic-attr branch January 19, 2022 21:54
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Jan 20, 2022 •
edited
Loading

Thanks for merging :) BTW, we should backport this to 3.10 and 3.9. Agreed, @zware?

@miss-islington
Copy link
Contributor

miss-islington commented Jan 20, 2022

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Jan 20, 2022

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Jan 20, 2022

Sorry @erlend-aasland, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 71734d0b9ca584bcbdcb2fb44ae16bb2fbfcaf6e 3.10

@miss-islington miss-islington self-assigned this Jan 20, 2022
@miss-islington
Copy link
Contributor

miss-islington commented Jan 20, 2022

Sorry, @erlend-aasland, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 71734d0b9ca584bcbdcb2fb44ae16bb2fbfcaf6e 3.9

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jan 20, 2022
@bedevere-bot
Copy link

bedevere-bot commented Jan 20, 2022

GH-30726 is a backport of this pull request to the 3.10 branch.

erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request Jan 20, 2022
[3.10] Mark all clinic headers as generated (pythonGH-30679).
96e30be 
(cherry picked from commit 71734d0)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@bedevere-bot
Copy link

bedevere-bot commented Jan 20, 2022

GH-30728 is a backport of this pull request to the 3.9 branch.

erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request Jan 20, 2022
[3.9] Mark all clinic headers as generated (pythonGH-30679).
91b5eb4 
(cherry picked from commit 71734d0)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
miss-islington pushed a commit that referenced this pull request Jan 20, 2022
[3.10] Mark all clinic headers as generated (GH-30679). (GH-30726)
876ade1 
(cherry picked from commit 71734d0)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
miss-islington pushed a commit that referenced this pull request Jan 20, 2022
[3.9] Mark all clinic headers as generated (GH-30679). (GH-30728)
e8e71c4 
(cherry picked from commit 71734d0)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@hello-adam
[3.9] Mark all clinic headers as generated (pythonGH-30679). (pythonG…
96f2591 
…H-30728)

(cherry picked from commit 71734d0)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@zware zware zware approved these changes

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@ammaraskar ammaraskar Awaiting requested review from ammaraskar

Assignees

@miss-islington miss-islington

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@erlend-aasland @miss-islington @bedevere-bot @JelleZijlstra @zware @kumaraditya303 @the-knights-who-say-ni