bpo-46411: Modernize exception handling in tests #30638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iritkatriel
requested review from
brettcannon,
encukou,
ericsnowcurrently,
ncoghlan,
vsajip and
warsaw
as code owners
iritkatriel
added
skip news
needs backport to 3.9
vsajip
reviewed
Jan 17, 2022
| @@ -5524,8 +5524,8 @@ def test_compute_rollover(self, when=when, exp=exp): | |||
| print('currentSecond: %s' % currentSecond, file=sys.stderr) | |||
| print('r: %s' % r, file=sys.stderr) | |||
| print('result: %s' % result, file=sys.stderr) | |||
| except Exception: | |||
| print('exception in diagnostic code: %s' % sys.exc_info()[1], file=sys.stderr) | |||
| except Exception as e: | |||
brettcannon
approved these changes
Jan 17, 2022
|
Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 18, 2022
…nGH-30638) (cherry picked from commit a287b31) Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
|
GH-30657 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 18, 2022
…nGH-30638) (cherry picked from commit a287b31) Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
|
GH-30658 is a backport of this pull request to the 3.9 branch. |
miss-islington
added a commit
that referenced
this pull request
Jan 18, 2022
miss-islington
added a commit
that referenced
this pull request
Jan 18, 2022
) (cherry picked from commit a287b31) Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
hello-adam
pushed a commit
to hello-adam/cpython
that referenced
this pull request
Jun 2, 2022
…ythonGH-30638) (pythonGH-30658) (cherry picked from commit a287b31) Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com> Automerge-Triggered-By: GH:iritkatriel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some tests the unnecessarily rely on sys.exc_info() (a relic of Python 2 I believe).
https://bugs.python.org/issue46411