Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-46332: use raise..from instead of assigning __cause__ and raising #30517

Merged
merged 2 commits into from
Jan 10, 2022
Merged

bpo-46332: use raise..from instead of assigning __cause__ and raising #30517

merged 2 commits into from
Jan 10, 2022

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Jan 10, 2022 •
edited by bedevere-bot
Loading

@iritkatriel iritkatriel requested a review from vsajip as a code owner January 10, 2022 14:23
@iritkatriel iritkatriel changed the title bpo-46332: use raise..from instead of assigning __cause__ and reraising bpo-46332: use raise..from instead of assigning __cause__ and raising Jan 10, 2022
asvetlov
asvetlov approved these changes Jan 10, 2022
View reviewed changes
Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct

@iritkatriel iritkatriel merged commit 0d63967 into python:main Jan 10, 2022
@iritkatriel iritkatriel deleted the bpo-46332 branch January 13, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsajip vsajip vsajip approved these changes

@asvetlov asvetlov asvetlov approved these changes

@thisisamardeep thisisamardeep thisisamardeep approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@iritkatriel @vsajip @asvetlov @thisisamardeep @the-knights-who-say-ni @bedevere-bot