-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-40479: Fix hashlib's usedforsecurity for OpenSSL 3.0.0 (GH-30455) #30455
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did check if the property flags are used correctly, they are, so it should work fine in real FIPS mode with a real FIPS module
didn't really review any other part
When you're done making the requested changes, leave the comment: And if you don't make the requested changes, you will be put in the comfy chair! |
I have made the requested changes; please review again |
Thanks for making the requested changes! @gpshead: please review the changes made to this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall good, though you've got a leftover debugging #if 1 in the code...
Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
Sorry, @tiran, I could not cleanly backport this to |
GH-30573 is a backport of this pull request to the 3.10 branch. |
…honGH-30455). (cherry picked from commit 443b308) Co-authored-by: Christian Heimes <christian@python.org>
GH-30574 is a backport of this pull request to the 3.9 branch. |
|
@tiran This stable buildbot started to fail with this PR. Can you take a look? |
https://bugs.python.org/issue40479