bpo-31135: ttk: fix LabeledScale and OptionMenu destroy() method #3025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
changed the title
bpo-31135: Call the parent destroy() method even if the used attribute doesn't exist. The LabeledScale.destroy() method now also explicitly clears label and scale attributes to help the garbage collector to destroy all widgets.
| pass | ||
| else: | ||
| del self._variable | ||
| Frame.destroy(self) | ||
| super().destroy() | ||
| self.label = None |
There was a problem hiding this comment.
I dislike when attributes "disappear". I prefer setting them to None. Moreover, "self.label = None" doesn't fail if destroy() is called twice, whereas "del self._variable" requires a try/except AttributeError.
| pass | ||
| else: | ||
| del self._variable | ||
| Frame.destroy(self) | ||
| super().destroy() |
There was a problem hiding this comment.
Parent's destroy() now is called even if this destroy() already was called. I.e. it can be called twice.
There was a problem hiding this comment.
Yes, it's a deliberate choice. All other ttk widgets now have the same behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call the parent destroy() method even if the used attribute doesn't
exist.
https://bugs.python.org/issue31135