-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-22047: [argparse] deprecate nested argument groups and mutually e… #30098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willingc
approved these changes
Dec 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @iritkatriel.
What was the rationale behind this? |
The background is in the issue. |
alpernebbi
added a commit
to alpernebbi/depthcharge-tools
that referenced
this pull request
Sep 26, 2022
This makes Groups able to somewhat properly wrap Arguments and other Groups, so that we can add @Group.add on top of an @argument() chain which already creates an implicit group for a single method. Nesting groups is slightly problematic because argparse doesn't really support them [1]. Most important issue for us is that the inner groups don't show up in the help message, but that is easily solved by flattening the arguments into the outermost group. [1] python/cpython#30098 Signed-off-by: Alper Nebi Yasak <alpernebiyasak@gmail.com>
luispadron
pushed a commit
to bazelbuild/rules_apple
that referenced
this pull request
Jan 3, 2024
…2334) Fixes #2310 by removing the mutually exclusive code signing arg group in `imported_dynamic_framework_processor.py`. Per python/cpython#30098 the nested configuration was never intended to work anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…xclusive groups
https://bugs.python.org/issue22047