Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-46044: Annotate deprecated sdists formats #30043

Merged
merged 2 commits into from
Dec 16, 2021
Merged

bpo-46044: Annotate deprecated sdists formats #30043

merged 2 commits into from
Dec 16, 2021

Conversation

Carreau
Copy link
Contributor

@Carreau Carreau commented Dec 11, 2021 •
edited by miss-islington
Loading

While this page have deprecated informations it is still heavily index
by Google.

Discussed on twitter: https://twitter.com/brettsky/status/1469465729082662916

https://bugs.python.org/issue46044

Automerge-Triggered-By: GH:brettcannon

@Carreau
bpo-46044: Annotate deprecated sdists formats
d0e7266 
While this page have deprecated informations it is still heavily index
by Google.

Discussed on twitter: https://twitter.com/brettsky/status/1469465729082662916
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Dec 11, 2021
@brettcannon brettcannon self-requested a review December 13, 2021 23:59
brettcannon
brettcannon requested changes Dec 15, 2021
View reviewed changes
Copy link
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight grammar tweak and adding a link to PyPI.

Doc/distutils/sourcedist.rst Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@Carreau @brettcannon
Update Doc/distutils/sourcedist.rst
4fdd46d 
Co-authored-by: Brett Cannon <brett@python.org>
@Carreau
Copy link
Contributor Author

Carreau commented Dec 16, 2021 •
edited by brettcannon
Loading

Done. Thanks !

I have made the requested changes; please review again.

@brettcannon
Copy link
Member

@Carreau for future reference, to tell the bot to update the state of the PR, you need to paste in the phrase, I have made the requested changes; please review again .

@brettcannon brettcannon self-requested a review December 16, 2021 19:56
@miss-islington miss-islington merged commit ecdc0cc into python:main Dec 16, 2021
@miss-islington
Copy link
Contributor

Thanks @Carreau for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-30154 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 16, 2021
@Carreau @miss-islington
bpo-46044: Annotate deprecated sdists formats (pythonGH-30043)
1b4dc81 
While this page have deprecated informations it is still heavily index
by Google.

Discussed on twitter: https://twitter.com/brettsky/status/1469465729082662916
(cherry picked from commit ecdc0cc)

Co-authored-by: Matthias Bussonnier <bussonniermatthias@gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Dec 16, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 16, 2021
@Carreau @miss-islington
bpo-46044: Annotate deprecated sdists formats (pythonGH-30043)
c36c977 
While this page have deprecated informations it is still heavily index
by Google.

Discussed on twitter: https://twitter.com/brettsky/status/1469465729082662916
(cherry picked from commit ecdc0cc)

Co-authored-by: Matthias Bussonnier <bussonniermatthias@gmail.com>
@bedevere-bot
Copy link

GH-30155 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Dec 16, 2021
bluetech
bluetech reviewed Dec 16, 2021
View reviewed changes
Doc/distutils/sourcedist.rst
| ``xztar`` | xz'ed tar file | \(5) |
| | (:file:`.tar.xz`) | |
+-----------+-------------------------+-------------+
| ``ztar`` | compressed tar file | \(5) |
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note 4 should probably remain here? Or else it should be removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum sorry, not sure how it got removed, likely a repeat command with vim that I messed up.

Carreau added a commit to Carreau/cpython that referenced this pull request Dec 17, 2021
@Carreau
Doc: fix typo introduced in python#30043
a548944 
See https://github.com/python/cpython/pull/30043/files#r770944718

My bad I likely messed up by using a repeat command in my editor
brettcannon added a commit that referenced this pull request Dec 17, 2021
@miss-islington @Carreau
@brettcannon @merwok
[3.10] bpo-46044: Annotate deprecated sdists formats (GH-30043) (#30154)
dbd1dc2 
(cherry picked from commit ecdc0cc)

Co-authored-by: Matthias Bussonnier <bussonniermatthias@gmail.com>
Co-authored-by: Brett Cannon <brett@python.org>
Co-authored-by: Éric <merwok@netwok.org>
brettcannon added a commit that referenced this pull request Dec 17, 2021
@miss-islington @Carreau
@brettcannon @merwok
[3.9] bpo-46044: Annotate deprecated sdists formats (GH-30043) (GH-30155
8202a7e 
)

Co-authored-by: Matthias Bussonnier <bussonniermatthias@gmail.com>
Co-authored-by: Brett Cannon <brett@python.org>
Co-authored-by: Éric <merwok@netwok.org>
miss-islington pushed a commit that referenced this pull request Dec 18, 2021
@Carreau
bpo-46044: Fix doc typo introduced in GH-30043 (GH-30171)
fe68486 
See https://github.com/python/cpython/pull/30043/files#r770944718

My bad I likely messed up by using a repeat command in my editor

Automerge-Triggered-By: GH:merwok
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluetech bluetech bluetech left review comments

@brettcannon brettcannon brettcannon approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Carreau @bedevere-bot @brettcannon @miss-islington @bluetech @the-knights-who-say-ni