bpo-46031: add POP_JUMP_IF_NOT_NONE and POP_JUMP_IF_NONE

[penguin-wwy]

https://bugs.python.org/issue46031

faster-cpython/ideas#154

[brandtbucher]

Thanks for the patch @penguin-wwy, and welcome to CPython!

[bedevere-bot]

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

[penguin-wwy]

I have made the requested changes; please review again.

[bedevere-bot]

Thanks for making the requested changes!

@brandtbucher: please review the changes made to this pull request.

[brandtbucher]

@markshannon, can you hit this with pyperformance to see what the numbers look like? Hopefully we can reproduce the reported 1% speedup.

[brandtbucher]

Ah, I didn't see you have some stale files. @penguin-wwy, can you run make regen-all, please?

[bedevere-bot]

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

[penguin-wwy]

@brandtbucher I resolve conflicts and run make regen-all, then nothing reminds me that I need to submit news.
@bedevere-bot I have made the requested changes; please review again.

[bedevere-bot]

Thanks for making the requested changes!

@brandtbucher: please review the changes made to this pull request.

[markshannon]

Shows a small speedup

[penguin-wwy]

@markshannon Thank you. Also, what are the configuration arguments for exec benchmark ? I used --enable-optimizations --with-lto

[markshannon]

@markshannon Thank you. Also, what are the configuration arguments for exec benchmark ? I used --enable-optimizations --with-lto

Yes, --enable-optimizations --with-lto is what we use.
Different builds and architectures can impact the results quite a lot, so it is quite likely that one machine will show a speedup of 1% and another, little or no speedup.

[markshannon]

Looks good.
You will need to add the new instructions to Doc/library/dis.rst
and increment the magic number in Lib/importlib/_bootstrap_external.py

[penguin-wwy]

Thank you! I have made the requested changes.

[markshannon]

LGTM.
I'm afraid that there are a few PRs adding or removing bytecodes at the moment, so you might need to wait a few days to avoid conflicts.

[penguin-wwy]

You are right
I have solved conflicts >= 5 times :)