-
-
Couldn't load subscription status.
- Fork 33.3k
bpo-45582: Fix test_embed failure during a PGO build on Windows #30014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I like this change better, but maybe we should get VPATH into sysconfig so that it can be used in the test? |
I think adding it as |
|
Thank you for the nice idea. I've finished the implementation. |
PGO-instrumented
_testembed.exeandgetpath.pyoften miscalculate the prefix path, when launched with allPYTHON*envvars removed.The new path calculation uses
VPATH, which is defined as"..\\.."inpythoncore.vcxproj. From PGO-instrumented folder,VPATHneeds to be"..\\..\\.."to resolve prefix.https://bugs.python.org/issue45582