-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-46016: fcntl module add FreeBSD's F_DUP2FD_CLOEXEC flag support. #29993
Conversation
@@ -0,0 +1 @@ | |||
- Adding F_DUP2FD_CLOEXEC flag from FreeBSD into the fcntl module. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would be nice to document the constant somewhere in Doc/library/fcntl.rst:
https://docs.python.org/dev/library/fcntl.html
You can also document the new constant in What's New in Python 3.11, add a new "fcntl" section to:
https://docs.python.org/dev/whatsnew/3.11.html#improved-modules
ce5ef5b
to
fbaeb28
Compare
Similar functionality on Linux is exposed through |
The bugs.python.org ticket for this PR is empty. Please update the ticket with an explanation what you are trying to archive. |
Merged, thanks. Adding 2 constants is fine. It would be great to document properly each constant in the fcntl doc (not only these 2 constants), but it can be done in a separated PR. os.dup2() has a |
F_DUP2FD / F_DUP2FD_CLOEXEC is more about os.dup2(), no? As I wrote, F_DUP2FD_CLOEXEC is already used by os.dup2() if available. I dont know if it is used on macOS. I no longer have access to a macOS machine to develop Python on it. |
https://bugs.python.org/issue46016