Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45929: extend json.tool --json-lines to ignore empty rows #29858

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

bpo-45929: extend json.tool --json-lines to ignore empty rows #29858

wants to merge 9 commits into from

Conversation

ZeeD
Copy link

@ZeeD ZeeD commented Nov 30, 2021 •
edited by bedevere-bot
Loading

As 45929 is something that bugged me, I though it would be helpful to propose a PR.
Please let me know if this is good enough

https://bugs.python.org/issue45929

@AlexWaygood AlexWaygood added the type-feature A feature request or enhancement label Dec 7, 2021
@github-actions
Copy link

github-actions bot commented Jan 7, 2022

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Jan 7, 2022
@MaxwellDupre
Copy link
Contributor

Fetched upstream
Cant pull PR:
cpython on  main [$] via 🐍 v3.11.0a3+
✦ ❯ gh pr checkout 29858
remote: Enumerating objects: 34, done.
remote: Counting objects: 100% (27/27), done.
remote: Total 34 (delta 27), reused 27 (delta 27), pack-reused 7
Unpacking objects: 100% (34/34), 9.20 KiB | 784.00 KiB/s, done.
From https://github.com/python/cpython
! [rejected] refs/pull/29858/head -> master (non-fast-forward)
exit status 1

@ZeeD
Copy link
Author

ZeeD commented Mar 8, 2022

@MaxwellDupre can you pull now the PR?

MaxwellDupre
MaxwellDupre approved these changes Apr 17, 2022
View reviewed changes
Copy link
Contributor

@MaxwellDupre MaxwellDupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran 16 tests in 3.341s
OK
Looks ok.

@ZeeD ZeeD mannequin mentioned this pull request Apr 10, 2022
Open
@arhadthedev arhadthedev added the stdlib Python modules in the Lib dir label Apr 1, 2023
@arhadthedev
Copy link
Member

@ezio-melotti, @rhettinger (as json experts)

@Eclips4
Copy link
Member

Eclips4 commented Jul 23, 2024

@python/organization-owners Can you block @sys-ptipu, please? There's a lot of spam messages from that account in different PRs.

@JacobCoffee
Copy link
Member

@Eclips4 the user has been blocked - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hongweipeng hongweipeng hongweipeng left review comments

@MaxwellDupre MaxwellDupre MaxwellDupre approved these changes

Assignees
No one assigned
Labels
awaiting core review stale Stale PR or inactive for long period of time. stdlib Python modules in the Lib dir type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@ZeeD @MaxwellDupre @arhadthedev @Eclips4 @JacobCoffee @hongweipeng @the-knights-who-say-ni @ezio-melotti @bedevere-bot @AlexWaygood