Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-45614: Fix traceback display for exceptions with invalid module name #29726

Merged

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Nov 23, 2021

This was found via missing test coverage.

https://bugs.python.org/issue45614

@iritkatriel iritkatriel added the type-bug An unexpected behavior, bug, or error label Nov 25, 2021
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@asvetlov
Copy link
Contributor

The PR worth the backporting probably.

@iritkatriel iritkatriel added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Nov 27, 2021
@iritkatriel iritkatriel merged commit 4dfae6f into python:main Nov 27, 2021
@iritkatriel iritkatriel deleted the bpo-45614-traceback-nonunicode-module branch November 27, 2021 22:00
@miss-islington
Copy link
Contributor

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Fedora Stable Clang Installed 3.x has failed when building commit 4dfae6f.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/350/builds/1038) and take a look at the build logs.
  4. Check if the failure is related to this commit (4dfae6f) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/350/builds/1038

Summary of the results of the build (if available):

Click to see traceback logs
rror: RPC failed; HTTP 504 curl 22 The requested URL returned error: 504
fatal: expected flush after ref listing

chmod: cannot access 'target/': No such file or directory

make: *** No rule to make target 'distclean'.  Stop.

@iritkatriel
Copy link
Member Author

@Mariatta the backports didn’t happen here for some reason. (The build failure is unrelated to this pr).

@Mariatta Mariatta added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes and removed needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Nov 28, 2021
@miss-islington
Copy link
Contributor

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @iritkatriel, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 4dfae6f38e1720ddafcdd68043e476ecb41cb4d5 3.10

@miss-islington
Copy link
Contributor

Sorry @iritkatriel, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 4dfae6f38e1720ddafcdd68043e476ecb41cb4d5 3.9

@Mariatta
Copy link
Member

Seems like there's a conflict. Please try doing the backport manually.

iritkatriel added a commit to iritkatriel/cpython that referenced this pull request Nov 28, 2021
@bedevere-bot
Copy link

GH-29827 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Nov 28, 2021
@bedevere-bot
Copy link

GH-29826 is a backport of this pull request to the 3.10 branch.

iritkatriel added a commit that referenced this pull request Nov 29, 2021
iritkatriel added a commit that referenced this pull request Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants