-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-45614: Fix traceback display for exceptions with invalid module name #29726
bpo-45614: Fix traceback display for exceptions with invalid module name #29726
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
The PR worth the backporting probably. |
Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
|
@Mariatta the backports didn’t happen here for some reason. (The build failure is unrelated to this pr). |
Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9. |
Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
Sorry, @iritkatriel, I could not cleanly backport this to |
Sorry @iritkatriel, I had trouble checking out the |
Seems like there's a conflict. Please try doing the backport manually. |
…ame (pythonGH-29726) (cherry picked from commit 4dfae6f)
…ame (pythonGH-29726) (cherry picked from commit 4dfae6f)
GH-29827 is a backport of this pull request to the 3.9 branch. |
GH-29826 is a backport of this pull request to the 3.10 branch. |
This was found via missing test coverage.
https://bugs.python.org/issue45614